Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PartialEq to Error #172

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Add PartialEq to Error #172

merged 1 commit into from
Sep 21, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Sep 13, 2023

Adding PartialEq to Error to make it more ergonomic for
consumers. Since the Error type implements Serialize and
Deserialize all of the error variants are simple types that implement
equivalence.

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Sep 13, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the size/S Small PRs label Sep 13, 2023
@github-actions github-actions bot added the rust Pull requests that update rust code label Sep 13, 2023
@meowblecoinbot meowblecoinbot requested a review from a team September 13, 2023 21:15
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

❌ Unreviewed dependencies found

Crate Version Reviews (N/2) LoC Left-Pad Index Geiger Flags
yare 1.0.2 0 89 11 0 ____
mc-sgx-dcap-sys-types 0.8.0 0 124 9 0 CB__
assert_matches 1.5.0 0 209 93 0 ____
mc-sgx-core-sys-types 0.8.0 0 273 7 0 CB__
subtle 2.5.0 0 440 162 9 ____
hex 0.4.3 0 474 160 0 ____
displaydoc 0.2.4 0 600 62 20 ____
x509-cert 0.2.3 0 1963 7 0 ____
textwrap 0.16.0 0 2234 73 0 ____
mc-sgx-core-types 0.8.0 0 2354 2 0 ____
p256 0.13.2 0 2545 28 0 ____
mc-sgx-dcap-types 0.8.0 0 2870 1 12 ____
rand 0.8.5 0 5273 69 32 ____
der 0.7.7 0 7848 28 0 ____
serde 1.0.171 0 10534 52 5 CB__
serde_json 1.0.103 0 12487 45 7 CB__

Cargo.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #172 (6edc402) into nick/cloneable-error (900cb1e) will not change coverage.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##           nick/cloneable-error     #172   +/-   ##
=====================================================
  Coverage                 98.50%   98.50%           
=====================================================
  Files                        13       13           
  Lines                      4403     4403           
=====================================================
  Hits                       4337     4337           
  Misses                       66       66           
Files Changed Coverage Δ
verifier/src/error.rs 88.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin force-pushed the nick/eq-and-partialeq-error branch 2 times, most recently from c8220e4 to ebcf0cd Compare September 13, 2023 21:28
@github-actions github-actions bot added size/XS Extra-Small PRs and removed size/S Small PRs rust Pull requests that update rust code labels Sep 13, 2023
@nick-mobilecoin nick-mobilecoin changed the title Add Eq and PartialEq to Error Add PartialEq to Error Sep 13, 2023
@nick-mobilecoin nick-mobilecoin requested review from eranrund and dolanbernard and removed request for a team September 14, 2023 15:28
Adding `PartialEq` to `Error` to make it more ergonomic for
consumers. Since the `Error` type implements `Serialize` and
`Deserialize` all of the error variants are simple types that implement
equivalence.
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Sep 21, 2023

Merge Activity

Base automatically changed from nick/cloneable-error to main September 21, 2023 21:43
@nick-mobilecoin nick-mobilecoin merged commit 3b2d161 into main Sep 21, 2023
20 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/eq-and-partialeq-error branch September 21, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Extra-Small PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants