-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PartialEq
to Error
#172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
❌ Unreviewed dependencies found
|
nick-mobilecoin
commented
Sep 13, 2023
Codecov Report
@@ Coverage Diff @@
## nick/cloneable-error #172 +/- ##
=====================================================
Coverage 98.50% 98.50%
=====================================================
Files 13 13
Lines 4403 4403
=====================================================
Hits 4337 4337
Misses 66 66
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nick-mobilecoin
force-pushed
the
nick/eq-and-partialeq-error
branch
2 times, most recently
from
September 13, 2023 21:28
c8220e4
to
ebcf0cd
Compare
github-actions
bot
added
size/XS
Extra-Small PRs
and removed
size/S
Small PRs
rust
Pull requests that update rust code
labels
Sep 13, 2023
nick-mobilecoin
commented
Sep 13, 2023
nick-mobilecoin
requested review from
eranrund and
dolanbernard
and removed request for
a team
September 14, 2023 15:28
eranrund
approved these changes
Sep 14, 2023
Adding `PartialEq` to `Error` to make it more ergonomic for consumers. Since the `Error` type implements `Serialize` and `Deserialize` all of the error variants are simple types that implement equivalence.
nick-mobilecoin
force-pushed
the
nick/cloneable-error
branch
from
September 21, 2023 21:34
fcde259
to
900cb1e
Compare
nick-mobilecoin
force-pushed
the
nick/eq-and-partialeq-error
branch
from
September 21, 2023 21:36
ebcf0cd
to
6edc402
Compare
Merge Activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
PartialEq
toError
to make it more ergonomic forconsumers. Since the
Error
type implementsSerialize
andDeserialize
all of the error variants are simple types that implementequivalence.